Applying new style to entire selection if partially present #1056
Conversation
tests/plugins/font/font.js
Outdated
| }, | ||
|
|
||
| // #1040 | ||
| 'test apply new style to entire selection if partially present': function() { |
There was a problem hiding this comment.
One more test checking if styles are not changed in any way if applied second time on the part of already styled element could be added.
tests/plugins/font/font.js
Outdated
| // #1040 | ||
| 'test apply new style to entire selection if partially present': function() { | ||
| var bot = this.editorBot; | ||
| bender.tools.selection.setWithHtml( bot.editor, '<h1><span style="font-family:Courier New,Courier,monospace">[Hello</span> world!]</h1>' ); |
There was a problem hiding this comment.
ffCourierNew could be also used here.
tests/plugins/font/font.js
Outdated
| bot.combo( 'Font', function( combo ) { | ||
| combo.onClick( 'Courier New' ); | ||
| this.wait( function() { | ||
| combo.onClick( 'Courier New' ); |
There was a problem hiding this comment.
Not sure why in this test combo is clicked two times? One should be enough to cover this case.
| @@ -0,0 +1,14 @@ | |||
| @bender-tags: 4.8.0, bug, 1040 | |||
| @bender-ui: collapsed | |||
| @bender-ckeditor-plugins: wysiwygarea, toolbar, font | |||
There was a problem hiding this comment.
The elementspath plugin could be useful, so tester could see if any strange markup wasn't created.
| @bender-ui: collapsed | ||
| @bender-ckeditor-plugins: wysiwygarea, toolbar, font | ||
|
|
||
| **Scenario:** |
There was a problem hiding this comment.
I would add a second scenario with font size and different selection (which will contain styles at the end, not at the beginning - so first changing size of world text and then selecting He{llo world} and reapplying the styles).
|
Overtaking this PR. |
f1ames
force-pushed
the
t/1040
branch
2 times, most recently
from
a1fa080
to
d5f566e
Compare
mlewand
changed the title
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
Yes
This PR contains
Closes #1040